Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout setting: Running Ignore Mouse #806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexKnauth
Copy link
Contributor

Add a layout setting for Ignore Mouse While Running and Not In Focus.

@AlexKnauth AlexKnauth force-pushed the mouse_pass_through-2 branch from 5183178 to 30a3fb6 Compare May 28, 2024 20:48
@AlexKnauth AlexKnauth force-pushed the mouse_pass_through-2 branch from 30a3fb6 to b34e2a4 Compare June 14, 2024 04:05
@AlexKnauth AlexKnauth force-pushed the mouse_pass_through-2 branch from b34e2a4 to 8331243 Compare June 30, 2024 20:09
@CryZe
Copy link
Collaborator

CryZe commented Aug 22, 2024

In LSO layouts are a bit different in that their purpose is only for rendering, they don't handle any interactions, auto splitting, manual game time or other platform specific stuff. They truly only visualize information. Similar settings like "Always on Top" for example are in the general settings for the specific frontend, if it can even support that. We likely want to have a way to override the general settings for specific games / splits anyway, so you can have different hotkeys for different games and stuff. So I don't think the layout is the place anymore in LSO for this setting.

@CryZe CryZe added enhancement An improvement for livesplit-core. needs further discussion It is unclear how to progress without making further decisions. feature A new user visible feature for livesplit-core. labels Aug 22, 2024
@AlexKnauth
Copy link
Contributor Author

One of the conveniences of doing it this way is importing existing .lsl LiveSplit layouts to convert them to .ls1l LiveSplit One layouts. Outside of conversion, the specific frontend settings do seem like a better place I guess.

@CryZe
Copy link
Collaborator

CryZe commented Aug 22, 2024

I think when parsing from a .lsl we can return not only a Layout but also some sort of AdditionalLslSettings that you could optionally apply.

@AlexKnauth AlexKnauth force-pushed the mouse_pass_through-2 branch 2 times, most recently from 02060b3 to f20ea76 Compare November 17, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. needs further discussion It is unclear how to progress without making further decisions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants